feat: apply frozen=True to all basemodels in python generated models#1072
Open
va1ha11a wants to merge 1 commit intosupabase:masterfrom
Open
feat: apply frozen=True to all basemodels in python generated models#1072va1ha11a wants to merge 1 commit intosupabase:masterfrom
va1ha11a wants to merge 1 commit intosupabase:masterfrom
Conversation
va1ha11a
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
When generating models to python the update and insert typed dicts make sense to be mutable but the base models do not (to me at least) and immutability provides some extra protections. i.e. foot gun removal.
What is the current behavior?
Pydantic basemodels are produced mutably
Issue is here
supabase/cli#5142
@o-santi
What is the new behavior?
Pydantic models are set to frozen
Additional context